Add Pluto-Eris cycle of curves #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidnevadoc
force-pushed
the
nev@pluto-eris
branch
from
447ae97
to
7ad3a13
Compare
CPerezz
requested changes
Nov 5, 2023
There was a problem hiding this comment.
First of all, nice work. It's really cool to get these curves implemented!
I have a couple of things that have written down while reviewing:
- README.md needs to be updated mentioning that pluto/eris curves are supported.
- All tests should be inside test modules please.
- Add comments for functions left unimplemented. Why were they unimplemented?
- Add a macro for all
Fq/p/p12/6...Reprstructs. All of them impl the same things over and over. So it's just boilerplate that we can save up. - All of the things that are publicly exported but not docummented should do the exercise of: 1. Think if they need to be exported. 2. if so, add docs. Otherwise change visibility.
|
I have addressed the comments relevant to this PR. However there are still some unresolved that I think should be fixed in a different PR. Mainly:
|
davidnevadoc
force-pushed
the
nev@pluto-eris
branch
6 times, most recently
from
3446308
to
9b7512d
Compare
Co-authored-by: Zhiyong-Gong <63758161+John-Gong-Math@users.noreply.github.com> address review comments Remove leftover add: test vectors for `test_from_u512` add and clean docs
Complete Pluto Eris docs
davidnevadoc
force-pushed
the
nev@pluto-eris
branch
from
9b7512d
to
9bfa6c4
Compare
CPerezz
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
We are inconsistent between our comments.
We have the hex representation of only some values for the constants that are defined in this PR.
I think we should either have them all or none. But it's quite confusing to only have "some of them".
We can address in a follow-up PR if you want. But this has to be addressed at some point.
Other than that, LGTM!
Good work with this!!
|
cc: @daira this might be of your interest! |
jonathanpwang
pushed a commit
to axiom-crypto/halo2curves
that referenced
this pull request
Dec 15, 2023
* add: Pluto/Eris curves Co-authored-by: Zhiyong-Gong <63758161+John-Gong-Math@users.noreply.github.com> address review comments Remove leftover add: test vectors for `test_from_u512` add and clean docs * Update Legendre impl Complete Pluto Eris docs
jonathanpwang
pushed a commit
to axiom-crypto/halo2curves
that referenced
this pull request
Dec 15, 2023
* add: Pluto/Eris curves Co-authored-by: Zhiyong-Gong <63758161+John-Gong-Math@users.noreply.github.com> address review comments Remove leftover add: test vectors for `test_from_u512` add and clean docs * Update Legendre impl Complete Pluto Eris docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the half-pairing cycle of prime-order curves described here: https://github.com/daira/pluto-eris
Pluto is a Barreto–Naehrig curve and its pairing implementation closely resembles that of
bn256curve. See the Optimal Ate pairing described in the article: https://eprint.iacr.org/2010/354.pdf.The constants for the fields and its extensions are derived these notebooks: https://github.com/davidnevadoc/ec-constants/tree/main/pluto_eris